Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc changes to get publish to Central to work OOTB #291

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

aaneja
Copy link
Contributor

@aaneja aaneja commented Feb 24, 2025

  • Fix signing plugin
  • Sign before publish in GH action
  • Fix pom tags

- Sign before publish in GH action
- Fix pom tags
@aaneja
Copy link
Contributor Author

aaneja commented Feb 24, 2025

To get signing to work, the signing keys must be present or provided as described at - https://docs.gradle.org/current/userguide/signing_plugin.html#sec:signatory_credentials

I could test this locally by creating a gradle.properties on my project root with the following content

signing.keyId=C24D9F85F91DB7D0
signing.password=<redacted>

I created a signing key using -

# Generate key, follow the interactive prompt to chose a signing key format and password
gpg --full-generate-key
# List the keys, and use theoutput to get the keyid
# E.g output : sec   rsa3072/C24D9F85F91DB7D0 2025-02-24 [SC]

gpg --list-secret-keys --keyid-format long

After I did this, running

./gradlew sign publishToMavenLocal resulted in -

~/W/o/p/tempto (mvnCentralPublishRelatedChanges|✚1) $ ls -o ~/.m2/repository/io/prestodb/tempto/tempto-kafka/1.54-SNAPSHOT/
total 100
-rw-r--r--. 1 anant  2207 Feb 24 19:31 maven-metadata-local.xml
-rw-r--r--. 1 anant   819 Feb 19 12:29 resolver-status.properties
-rw-r--r--. 1 anant 36123 Feb 24 19:31 tempto-kafka-1.54-SNAPSHOT-javadoc.jar
-rw-r--r--. 1 anant   518 Feb 24 19:31 tempto-kafka-1.54-SNAPSHOT-javadoc.jar.asc
-rw-r--r--. 1 anant  8752 Feb 24 19:31 tempto-kafka-1.54-SNAPSHOT-sources.jar
-rw-r--r--. 1 anant   518 Feb 24 19:31 tempto-kafka-1.54-SNAPSHOT-sources.jar.asc
-rw-r--r--. 1 anant 12231 Feb 24 19:31 tempto-kafka-1.54-SNAPSHOT.jar
-rw-r--r--. 1 anant   518 Feb 24 19:31 tempto-kafka-1.54-SNAPSHOT.jar.asc
-rw-r--r--. 1 anant  4415 Feb 24 19:31 tempto-kafka-1.54-SNAPSHOT.module
-rw-r--r--. 1 anant   518 Feb 24 19:31 tempto-kafka-1.54-SNAPSHOT.module.asc
-rw-r--r--. 1 anant  2375 Feb 24 19:31 tempto-kafka-1.54-SNAPSHOT.pom
-rw-r--r--. 1 anant   518 Feb 24 19:31 tempto-kafka-1.54-SNAPSHOT.pom.asc

Copy link
Contributor

@unidevel unidevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaneja aaneja merged commit e89c2fb into master Feb 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants