Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gpg signing with the passphrase cache #293

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

unidevel
Copy link
Contributor

@unidevel unidevel commented Feb 24, 2025

This is another way to fix the gpg signing issue with the passphrase cache by signing a dummy file.

Tested with https://github.com/unix280/tempto/actions/runs/13509698265/job/37747324801

@unidevel unidevel requested review from ZacBlanco and aaneja February 24, 2025 23:16
@unidevel unidevel marked this pull request as ready for review February 24, 2025 23:16
@unidevel unidevel changed the title Fix gpg signing with the passpharse cache Fix gpg signing with the passphrase cache Feb 24, 2025
echo "${{ secrets.GPG_SECRET }}" > ${{ env.GPG_KEY_FILE }}
chmod 600 ${{ env.GPG_KEY_FILE }}
gpg --import --batch ${{ env.GPG_KEY_FILE }}
touch /tmp/dummy.txt && gpg --batch --yes --pinentry-mode loopback --passphrase "${{ secrets.GPG_PASSPHRASE }}" --sign /tmp/dummy.txt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cached the passphrase here

@ZacBlanco
Copy link
Contributor

It looks like you actually ran the release action. Can you verify if the GPG signing checks at sonatype central were able to pass?

@unidevel
Copy link
Contributor Author

It looks like you actually ran the release action. Can you verify if the GPG signing checks at sonatype central were able to pass?

@ZacBlanco I'm using a test gpg key, which not send to the public key servers. The GPG keys used in action are set as secrets, I can not verify it locally.

@unidevel unidevel merged commit ea07a1e into prestodb:master Feb 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants