Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - Card with picture tag gets cutoff #929

Open
seangolob opened this issue Feb 24, 2025 · 0 comments
Open

🐛 [BUG] - Card with picture tag gets cutoff #929

seangolob opened this issue Feb 24, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@seangolob
Copy link
Collaborator

seangolob commented Feb 24, 2025

Describe the bug

Related to: #911

When I try to leverage as="picture" on the Card.Image, I am seeing a missing rounded border at the bottom.

Reproduction steps

This error is not in production. However, if yo would like to reproduce the issue:

1. Go to https://github.com/solutions
2. Inspect the row of cards towards the bottom of the page, remove the inline "display: block" from the picture tag within the card. (That is the workaround)
3. Observe the cutoff bottom edges of the card

Expected behavior

I would expect the picture to have rounded edges at the bottom.

Screenshots

Before (no picture tag):

Image

After (with picture tag):

Image

I believe the issue is the picture tag in this case has display: inline-block style on it which is causing 4px of whitespace under the image. I have a workaround in place to avoid this issue so I am by no means blocked.

Inspect view (with picture tag):

Image

Browsers

No response

OS

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant