Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - Rivers with picture tag do not always have rounded borders #930

Open
seangolob opened this issue Feb 24, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@seangolob
Copy link
Collaborator

seangolob commented Feb 24, 2025

Describe the bug

Hi there! I am experiencing an issue with the "River" element when I try to leverage the picture tag. The picture element is missing a height: 100% style so it doesn't consistently fill the height of its container. I believe we will need to adjust https://github.com/primer/brand/blob/main/packages/react/src/river/river-shared.module.css#L17 to add support for making the picture tag height: 100%.

I have a workaround in place so this doesn't block me at all.

Reproduction steps

1. Go to https://github.com/social-impact/focus-areas/environmental-sustainability with a logged in GH account
2. Look at the first river element, remove the inline `width` and `height` styles from the `picture` tag.
3. Observe behavior

Expected behavior

I would expect the picture to take up 100 height and not have cutoff edges at the bottom.

Screenshots

Image

Browsers

No response

OS

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant