Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge shadow tokens #1184

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Merge shadow tokens #1184

merged 2 commits into from
Feb 6, 2025
+318 −384

Conversation

lukasoppermann
Copy link
Contributor

Summary

List of notable changes:

What should reviewers focus on?

Steps to test:

@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Feb 6, 2025
@lukasoppermann lukasoppermann self-assigned this Feb 6, 2025
@lukasoppermann lukasoppermann requested review from a team as code owners February 6, 2025 14:11
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ec30523

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025 •
edited
Loading

Design Token Diff (StyleLint)

The message is too long to be displayed here. For more details, please check the job summary.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025 •
edited
Loading

Design Token Diff (Figma)

/figma/figma.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/figma.json	2025-02-06 16:05:17.658745894 +0000
@@ -79,8 +79,8 @@
     ],
     "groups": [
       "component shadow",
-        "shadow",
       "component (internal)",
+        "shadow",
       "component",
       "semantic",
       "syntax"
@@ -110,15 +110,6 @@
   "dist/figma/scales/dark.json",
   "dist/figma/scales/light-high-constrast.json",
   "dist/figma/scales/light.json",
-    "dist/figma/shadows/dark-colorblind.json",
-    "dist/figma/shadows/dark-dimmed.json",
-    "dist/figma/shadows/dark-high-contrast.json",
-    "dist/figma/shadows/dark-tritanopia.json",
-    "dist/figma/shadows/dark.json",
-    "dist/figma/shadows/light-colorblind.json",
-    "dist/figma/shadows/light-high-contrast.json",
-    "dist/figma/shadows/light-tritanopia.json",
-    "dist/figma/shadows/light.json",
   "dist/figma/themes/dark-colorblind.json",
   "dist/figma/themes/dark-dimmed.json",
   "dist/figma/themes/dark-high-contrast.json",

/figma/themes/dark-colorblind.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/themes/dark-colorblind.json	2025-02-06 16:05:14.835735145 +0000
@@ -2042,106 +2042,6 @@
   "group": "shadow"
 },
 {
-    "name": "shadow/floating/legacy/1/offsetX",
-    "value": 0,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark protanopia deuteranopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/offsetY",
-    "value": 6,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark protanopia deuteranopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/blur",
-    "value": 12,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark protanopia deuteranopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/spread",
-    "value": -3,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark protanopia deuteranopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/color",
-    "value": {
-      "r": 0.00392156862745098,
-      "g": 0.01568627450980392,
-      "b": 0.03529411764705882,
-      "a": 0.4
-    },
-    "type": "COLOR",
-    "scopes": ["EFFECT_COLOR"],
-    "mode": "dark protanopia deuteranopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/offsetX",
-    "value": 0,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark protanopia deuteranopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/offsetY",
-    "value": 6,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark protanopia deuteranopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/blur",
-    "value": 18,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark protanopia deuteranopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/spread",
-    "value": 0,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark protanopia deuteranopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/color",
-    "value": {
-      "r": 0.00392156862745098,
-      "g": 0.01568627450980392,
-      "b": 0.03529411764705882,
-      "a": 0.4
-    },
-    "type": "COLOR",
-    "scopes": ["EFFECT_COLOR"],
-    "mode": "dark protanopia deuteranopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
   "name": "focus/outlineColor",
   "value": {
     "r": 0.12156862745098039,

/figma/themes/dark-dimmed.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/themes/dark-dimmed.json	2025-02-06 16:05:13.991731921 +0000
@@ -2037,106 +2037,6 @@
   "group": "shadow"
 },
 {
-    "name": "shadow/floating/legacy/1/offsetX",
-    "value": 0,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark dimmed",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/offsetY",
-    "value": 6,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark dimmed",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/blur",
-    "value": 12,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark dimmed",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/spread",
-    "value": -3,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark dimmed",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/color",
-    "value": {
-      "r": 0.10980392156862745,
-      "g": 0.12941176470588237,
-      "b": 0.1568627450980392,
-      "a": 0.4
-    },
-    "type": "COLOR",
-    "scopes": ["EFFECT_COLOR"],
-    "mode": "dark dimmed",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/offsetX",
-    "value": 0,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark dimmed",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/offsetY",
-    "value": 6,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark dimmed",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/blur",
-    "value": 18,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark dimmed",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/spread",
-    "value": 0,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark dimmed",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/color",
-    "value": {
-      "r": 0.10980392156862745,
-      "g": 0.12941176470588237,
-      "b": 0.1568627450980392,
-      "a": 0.4
-    },
-    "type": "COLOR",
-    "scopes": ["EFFECT_COLOR"],
-    "mode": "dark dimmed",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
   "name": "focus/outlineColor",
   "value": {
     "r": 0.19215686274509805,

/figma/themes/dark-high-contrast.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/themes/dark-high-contrast.json	2025-02-06 16:05:15.292736890 +0000
@@ -2051,106 +2051,6 @@
   "group": "shadow"
 },
 {
-    "name": "shadow/floating/legacy/1/offsetX",
-    "value": 0,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark high contrast",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/offsetY",
-    "value": 6,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark high contrast",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/blur",
-    "value": 12,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark high contrast",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/spread",
-    "value": -3,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark high contrast",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/color",
-    "value": {
-      "r": 0.00392156862745098,
-      "g": 0.01568627450980392,
-      "b": 0.03529411764705882,
-      "a": 0.4
-    },
-    "type": "COLOR",
-    "scopes": ["EFFECT_COLOR"],
-    "mode": "dark high contrast",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/offsetX",
-    "value": 0,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark high contrast",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/offsetY",
-    "value": 6,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark high contrast",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/blur",
-    "value": 18,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark high contrast",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/spread",
-    "value": 0,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark high contrast",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/color",
-    "value": {
-      "r": 0.00392156862745098,
-      "g": 0.01568627450980392,
-      "b": 0.03529411764705882,
-      "a": 0.4
-    },
-    "type": "COLOR",
-    "scopes": ["EFFECT_COLOR"],
-    "mode": "dark high contrast",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
   "name": "focus/outlineColor",
   "value": {
     "r": 0.25098039215686274,

/figma/themes/dark-tritanopia.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/themes/dark-tritanopia.json	2025-02-06 16:05:14.414733537 +0000
@@ -2037,106 +2037,6 @@
   "group": "shadow"
 },
 {
-    "name": "shadow/floating/legacy/1/offsetX",
-    "value": 0,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark tritanopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/offsetY",
-    "value": 6,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark tritanopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/blur",
-    "value": 12,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark tritanopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/spread",
-    "value": -3,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark tritanopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/color",
-    "value": {
-      "r": 0.00392156862745098,
-      "g": 0.01568627450980392,
-      "b": 0.03529411764705882,
-      "a": 0.4
-    },
-    "type": "COLOR",
-    "scopes": ["EFFECT_COLOR"],
-    "mode": "dark tritanopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/offsetX",
-    "value": 0,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark tritanopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/offsetY",
-    "value": 6,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark tritanopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/blur",
-    "value": 18,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark tritanopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/spread",
-    "value": 0,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark tritanopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/color",
-    "value": {
-      "r": 0.00392156862745098,
-      "g": 0.01568627450980392,
-      "b": 0.03529411764705882,
-      "a": 0.4
-    },
-    "type": "COLOR",
-    "scopes": ["EFFECT_COLOR"],
-    "mode": "dark tritanopia",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
   "name": "focus/outlineColor",
   "value": {
     "r": 0.12156862745098039,

/figma/themes/dark.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/themes/dark.json	2025-02-06 16:05:13.574730329 +0000
@@ -2040,106 +2040,6 @@
   "group": "shadow"
 },
 {
-    "name": "shadow/floating/legacy/1/offsetX",
-    "value": 0,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/offsetY",
-    "value": 6,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/blur",
-    "value": 12,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/spread",
-    "value": -3,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/1/color",
-    "value": {
-      "r": 0.00392156862745098,
-      "g": 0.01568627450980392,
-      "b": 0.03529411764705882,
-      "a": 0.4
-    },
-    "type": "COLOR",
-    "scopes": ["EFFECT_COLOR"],
-    "mode": "dark",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/offsetX",
-    "value": 0,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/offsetY",
-    "value": 6,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/blur",
-    "value": 18,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/spread",
-    "value": 0,
-    "type": "FLOAT",
-    "scopes": ["EFFECT_FLOAT"],
-    "mode": "dark",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
-    "name": "shadow/floating/legacy/2/color",
-    "value": {
-      "r": 0.00392156862745098,
-      "g": 0.01568627450980392,
-      "b": 0.03529411764705882,
-      "a": 0.4
-    },
-    "type": "COLOR",
-    "scopes": ["EFFECT_COLOR"],
-    "mode": "dark",
-    "collection": "mode",
-    "group": "shadow"
-  },
-  {
   "name": "focus/outlineColor",
   "value": {
     "r": 0.12156862745098039,

@github-actions github-actions bot temporarily deployed to Preview (Storybook) February 6, 2025 14:13 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) February 6, 2025 16:06 Inactive
@lukasoppermann lukasoppermann merged commit fa5426c into main Feb 6, 2025
27 checks passed
@lukasoppermann lukasoppermann deleted the shadow-file-merge branch February 6, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/css-reviewers

Assignees

@lukasoppermann lukasoppermann

Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukasoppermann