Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose backdrop to figma users #1188

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Expose backdrop to figma users #1188

merged 1 commit into from
Feb 10, 2025

Conversation

lukasoppermann
Copy link
Contributor

Summary

List of notable changes:

What should reviewers focus on?

Steps to test:

@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Feb 10, 2025
@lukasoppermann lukasoppermann self-assigned this Feb 10, 2025
@lukasoppermann lukasoppermann requested review from a team as code owners February 10, 2025 09:25
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2025

⚠️ No Changeset found

Latest commit: f17253e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Design Token Diff (StyleLint)

/styleLint/functional/themes/dark-colorblind.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/dark-colorblind.json	2025-02-10 09:25:57.954851383 +0000
@@ -27592,7 +27592,7 @@
   "$extensions": {
     "org.primer.figma": {
       "collection": "mode",
-        "group": "component (internal)",
+        "group": "component",
       "scopes": ["bgColor"]
     },
     "org.primer.overrides": {
@@ -27611,7 +27611,7 @@
     "$extensions": {
       "org.primer.figma": {
         "collection": "mode",
-          "group": "component (internal)",
+          "group": "component",
         "scopes": ["bgColor"]
       },
       "org.primer.overrides": {

/styleLint/functional/themes/dark-dimmed.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/dark-dimmed.json	2025-02-10 09:25:54.826850529 +0000
@@ -27584,7 +27584,7 @@
   "$extensions": {
     "org.primer.figma": {
       "collection": "mode",
-        "group": "component (internal)",
+        "group": "component",
       "scopes": ["bgColor"]
     },
     "org.primer.overrides": {
@@ -27603,7 +27603,7 @@
     "$extensions": {
       "org.primer.figma": {
         "collection": "mode",
-          "group": "component (internal)",
+          "group": "component",
         "scopes": ["bgColor"]
       },
       "org.primer.overrides": {

/styleLint/functional/themes/dark-high-contrast.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/dark-high-contrast.json	2025-02-10 09:25:59.530851813 +0000
@@ -27598,7 +27598,7 @@
   "$extensions": {
     "org.primer.figma": {
       "collection": "mode",
-        "group": "component (internal)",
+        "group": "component",
       "scopes": ["bgColor"]
     },
     "org.primer.overrides": {
@@ -27617,7 +27617,7 @@
     "$extensions": {
       "org.primer.figma": {
         "collection": "mode",
-          "group": "component (internal)",
+          "group": "component",
         "scopes": ["bgColor"]
       },
       "org.primer.overrides": {

/styleLint/functional/themes/dark-tritanopia.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/dark-tritanopia.json	2025-02-10 09:25:56.388850955 +0000
@@ -27590,7 +27590,7 @@
   "$extensions": {
     "org.primer.figma": {
       "collection": "mode",
-        "group": "component (internal)",
+        "group": "component",
       "scopes": ["bgColor"]
     },
     "org.primer.overrides": {
@@ -27609,7 +27609,7 @@
     "$extensions": {
       "org.primer.figma": {
         "collection": "mode",
-          "group": "component (internal)",
+          "group": "component",
         "scopes": ["bgColor"]
       },
       "org.primer.overrides": {

/styleLint/functional/themes/dark.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/dark.json	2025-02-10 09:25:53.404850204 +0000
@@ -27582,7 +27582,7 @@
   "$extensions": {
     "org.primer.figma": {
       "collection": "mode",
-        "group": "component (internal)",
+        "group": "component",
       "scopes": ["bgColor"]
     },
     "org.primer.overrides": {
@@ -27601,7 +27601,7 @@
     "$extensions": {
       "org.primer.figma": {
         "collection": "mode",
-          "group": "component (internal)",
+          "group": "component",
         "scopes": ["bgColor"]
       },
       "org.primer.overrides": {

/styleLint/functional/themes/light-colorblind.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/light-colorblind.json	2025-02-10 09:25:50.378849811 +0000
@@ -27556,7 +27556,7 @@
   "$extensions": {
     "org.primer.figma": {
       "collection": "mode",
-        "group": "component (internal)",
+        "group": "component",
       "scopes": ["bgColor"]
     },
     "org.primer.overrides": {
@@ -27575,7 +27575,7 @@
     "$extensions": {
       "org.primer.figma": {
         "collection": "mode",
-          "group": "component (internal)",
+          "group": "component",
         "scopes": ["bgColor"]
       },
       "org.primer.overrides": {

/styleLint/functional/themes/light-high-contrast.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/light-high-contrast.json	2025-02-10 09:25:51.828849999 +0000
@@ -27556,7 +27556,7 @@
   "$extensions": {
     "org.primer.figma": {
       "collection": "mode",
-        "group": "component (internal)",
+        "group": "component",
       "scopes": ["bgColor"]
     },
     "org.primer.overrides": {
@@ -27575,7 +27575,7 @@
     "$extensions": {
       "org.primer.figma": {
         "collection": "mode",
-          "group": "component (internal)",
+          "group": "component",
         "scopes": ["bgColor"]
       },
       "org.primer.overrides": {

/styleLint/functional/themes/light-tritanopia.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/light-tritanopia.json	2025-02-10 09:25:48.848849612 +0000
@@ -27556,7 +27556,7 @@
   "$extensions": {
     "org.primer.figma": {
       "collection": "mode",
-        "group": "component (internal)",
+        "group": "component",
       "scopes": ["bgColor"]
     },
     "org.primer.overrides": {
@@ -27575,7 +27575,7 @@
     "$extensions": {
       "org.primer.figma": {
         "collection": "mode",
-          "group": "component (internal)",
+          "group": "component",
         "scopes": ["bgColor"]
       },
       "org.primer.overrides": {

/styleLint/functional/themes/light.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/functional/themes/light.json	2025-02-10 09:25:47.349843348 +0000
@@ -27552,7 +27552,7 @@
   "$extensions": {
     "org.primer.figma": {
       "collection": "mode",
-        "group": "component (internal)",
+        "group": "component",
       "scopes": ["bgColor"]
     },
     "org.primer.overrides": {
@@ -27571,7 +27571,7 @@
     "$extensions": {
       "org.primer.figma": {
         "collection": "mode",
-          "group": "component (internal)",
+          "group": "component",
         "scopes": ["bgColor"]
       },
       "org.primer.overrides": {

@github-actions GitHub Actions
Copy link
Contributor

Design Token Diff (Figma)

/figma/themes/dark-colorblind.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/themes/dark-colorblind.json	2025-02-10 09:26:06.569854184 +0000
@@ -5343,7 +5343,7 @@
   "reference": "base/color/dark/base/color/neutral/3",
   "collection": "mode",
   "mode": "dark protanopia deuteranopia",
-    "group": "component (internal)",
+    "group": "component",
   "scopes": ["FRAME_FILL", "SHAPE_FILL"]
 },
 {

/figma/themes/dark-dimmed.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/themes/dark-dimmed.json	2025-02-10 09:26:05.671853853 +0000
@@ -5337,7 +5337,7 @@
   "reference": "base/color/dark/base/color/neutral/4",
   "collection": "mode",
   "mode": "dark dimmed",
-    "group": "component (internal)",
+    "group": "component",
   "scopes": ["FRAME_FILL", "SHAPE_FILL"]
 },
 {

/figma/themes/dark-high-contrast.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/themes/dark-high-contrast.json	2025-02-10 09:26:07.005854345 +0000
@@ -5353,7 +5353,7 @@
   "reference": "base/color/dark/base/color/neutral/11",
   "collection": "mode",
   "mode": "dark high contrast",
-    "group": "component (internal)",
+    "group": "component",
   "scopes": ["FRAME_FILL", "SHAPE_FILL"]
 },
 {

/figma/themes/dark-tritanopia.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/themes/dark-tritanopia.json	2025-02-10 09:26:06.110854015 +0000
@@ -5337,7 +5337,7 @@
   "reference": "base/color/dark/base/color/neutral/3",
   "collection": "mode",
   "mode": "dark tritanopia",
-    "group": "component (internal)",
+    "group": "component",
   "scopes": ["FRAME_FILL", "SHAPE_FILL"]
 },
 {

/figma/themes/dark.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/themes/dark.json	2025-02-10 09:26:05.255853700 +0000
@@ -10230,7 +10230,7 @@
   "reference": "base/color/dark/base/color/neutral/3",
   "collection": "mode",
   "mode": "dark",
-    "group": "component (internal)",
+    "group": "component",
   "scopes": ["FRAME_FILL", "SHAPE_FILL"]
 },
 {

/figma/themes/light-colorblind.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/themes/light-colorblind.json	2025-02-10 09:26:04.399853385 +0000
@@ -5334,7 +5334,7 @@
   "reference": "base/color/light/base/color/neutral/7",
   "collection": "mode",
   "mode": "light protanopia deuteranopia",
-    "group": "component (internal)",
+    "group": "component",
   "scopes": ["FRAME_FILL", "SHAPE_FILL"]
 },
 {

/figma/themes/light-high-contrast.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/themes/light-high-contrast.json	2025-02-10 09:26:04.814853538 +0000
@@ -5336,7 +5336,7 @@
   "reference": "base/color/light/base/color/neutral/11",
   "collection": "mode",
   "mode": "light high contrast",
-    "group": "component (internal)",
+    "group": "component",
   "scopes": ["FRAME_FILL", "SHAPE_FILL"]
 },
 {

/figma/themes/light-tritanopia.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/themes/light-tritanopia.json	2025-02-10 09:26:03.948853219 +0000
@@ -5334,7 +5334,7 @@
   "reference": "base/color/light/base/color/neutral/7",
   "collection": "mode",
   "mode": "light tritanopia",
-    "group": "component (internal)",
+    "group": "component",
   "scopes": ["FRAME_FILL", "SHAPE_FILL"]
 },
 {

/figma/themes/light.json

 
+++ /home/runner/work/primitives/primitives/dist/figma/themes/light.json	2025-02-10 09:26:03.493853051 +0000
@@ -5334,7 +5334,7 @@
   "reference": "base/color/light/base/color/neutral/7",
   "collection": "mode",
   "mode": "light",
-    "group": "component (internal)",
+    "group": "component",
   "scopes": ["FRAME_FILL", "SHAPE_FILL"]
 },
 {

@github-actions github-actions bot temporarily deployed to Preview (Storybook) February 10, 2025 09:27 Inactive
@lukasoppermann lukasoppermann merged commit cc55266 into main Feb 10, 2025
31 checks passed
@lukasoppermann lukasoppermann deleted the figma-overlay-backdrop branch February 10, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/css-reviewers

Assignees

@lukasoppermann lukasoppermann

Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukasoppermann