Updating Pulse code to new matcher (for taramana_cbor branch) #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Repurposing this PR for more cleanup, since CI failed at it takes really long. I'm not sure why it failed, it's succeeding locally. |
In the successful case, these tests output F* errors that will then show up in logs for CI runs (e.g. https://github.com/mtzguido/FStar/actions/runs/13357223228). Redirect the output and error output to files so they do not show up, but can still be inspected manually.
Generated by
```
for file in $(git grep -l '```pulse')
do
sed -i '/^module[^=]*$/a #lang-pulse
/```/d' $file
done
```
Avoid matches, avoid explicit Mktuple
Slice now defines pts_to, and will shadow the one in Pervasives if we open it after that. Would be nice to have a general convention. FStarLang/pulse#351
No need to delete everything if qd.exe and the RFCs remained unchanged.
mtzguido
changed the title
This reverts commit d0d3e18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repurposing this PR to include updates related to making everparse work with FStarLang/pulse#344.
@tahina-pro : I am almost done with the fixes, there are three remaining admits. Some of the rewrites were pretty painful as we don't have an
unfold allor similar in Pulse, and also uncovered some F* and Pulse bugs (so it's great we tried this project before merging). I can finish the admits soon, but you may want to beat me to it.