Fix race condition when restarting plugins that leads to crash

project-gauntlet · Sep 8, 2024 · cdcda9f · cdcda9f
1 parent 56096f8
commit cdcda9f
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/rust/server/src/plugins/run_status.rs b/rust/server/src/plugins/run_status.rs
@@ -34,7 +34,7 @@ impl RunStatusHolder {
         let mut running_plugins = self.running_plugins.lock().expect("lock is poisoned");
 
         running_plugins
-            .get(plugin_id)
+            .remove(plugin_id)
             .expect("value should always exist for specified id")
             .cancel()
     }
@@ -56,10 +56,3 @@ impl RunStatusGuard {
             .cancelled_owned()
     }
 }
-
-impl Drop for RunStatusGuard {
-    fn drop(&mut self) {
-        let mut running_plugins = self.running_plugins.lock().expect("lock is poisoned");
-        running_plugins.remove(&self.id);
-    }
-}