Add logic to fetch index search stats for groups #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pieter Van Isacker <[email protected]>
SuperQ
requested changes
Jan 19, 2022
| @@ -70,6 +70,9 @@ func main() { | |||
| esExportIndicesSettings = kingpin.Flag("es.indices_settings", | |||
| "Export stats for settings of all indices of the cluster."). | |||
| Default("false").Envar("ES_INDICES_SETTINGS").Bool() | |||
| esExportIndicesSearchGroups = kingpin.Flag("es.indices_search_groups", | |||
| "Export search stats of all indices of the cluster by group."). | |||
| Default("false").Envar("ES_INDICES_TAGS").Bool() | |||
There was a problem hiding this comment.
We've stopped using ENV vars here.
Suggested change
| Default("false").Envar("ES_INDICES_TAGS").Bool() | |
| Default("false").Bool() |
|
Also needs a rebase. |
|
@pvanisacker Hi, Are you planing to finish the PR? I am also interested in this functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the needed to fix #223
There's some code duplication that can probably be cleaned up. As this is the first time I'm writing go I'm looking for feedback on how to fix/improve that.
Closes: #223