Add command line option to explicitly disable lock_wait_timeout (adds possibility to opt out of breaking changes with older versions) #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 21, 2024 19:07
Signed-off-by: Francisco Esteveira <[email protected]>
Signed-off-by: Francisco Esteveira <[email protected]>
Signed-off-by: Francisco Esteveira <[email protected]>
festeveira
changed the title
|
I'm not generally a fan of "magic values" like this. I prefer more explicit settings. |
…_wait_timeout_fix
Signed-off-by: Francisco Esteveira <[email protected]>
festeveira
changed the title
|
Hello, thank you for your feedback! I have added a command line parameter to explicitly disable the option. What do you think? |
SuperQ
requested changes
Feb 20, 2025
README.md
Outdated
| @@ -145,6 +145,7 @@ mysqld.username | Username to be used for connecting | |||
| config.my-cnf | Path to .my.cnf file to read MySQL credentials from. (default: `~/.my.cnf`) | |||
| log.level | Logging verbosity (default: info) | |||
| exporter.lock_wait_timeout | Set a lock_wait_timeout (in seconds) on the connection to avoid long metadata locking. (default: 2) | |||
| exporter.disable_lock_wait_timeout | Disable the lock_wait_timeout connection parameter. Makes the exporter compatible with older versions of MySQL. (default: false) | |||
There was a problem hiding this comment.
I prefer "positive" flags, so that we don't have double negative behavior.
The disable would be --no-exporter.enable_lock_wait_timeout.
Suggested change
| exporter.disable_lock_wait_timeout | Disable the lock_wait_timeout connection parameter. Makes the exporter compatible with older versions of MySQL. (default: false) | |
| exporter.enable_lock_wait_timeout | Disable the lock_wait_timeout connection parameter. Makes the exporter compatible with older versions of MySQL. (default: true) |
|
Yes, as a boolean flag is better. Thanks. |
Signed-off-by: Francisco Esteveira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a command line option to the exporter allowing the user to disable the lock_wait_timeout MySQL connection parameter making the exporter work again with older versions of mysql, while still behaving the same way by default.
Was really helpful for me, I need to monitor several instances in multi target mode and most of them are unsupported versions. Unless you see a problem with this I think it would be nice to have it merged.