-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
160 toggle for override data when importing siblings ordering from main #75
Open
soimugeoWB
wants to merge
12
commits into
main
Choose a base branch
from
160-toggle-for-override-data-when-importing-siblings-ordering-from-main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
160 toggle for override data when importing siblings ordering from main #75
soimugeoWB
wants to merge
12
commits into
main
from
160-toggle-for-override-data-when-importing-siblings-ordering-from-main
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nual test if it works.
…licate when importing the same file multiple times. Added OrderedChildrenDocumentServiceTest, ProjectOrderedChildrenMapperTest and ProcessUploadedSiblingsOrderingCommandHandlerIT. still need to fix the test where we check for duplicates.
…ultiple times. Added ordering to GetEntityHierarchyChildrenActionHandler
…he new structure for ProjectOrderedChildren. Struggeled to create integration test for GetEntityHierarchyChildrenActionHandler, eventually scrapped it and create integration test for ProjectOrderedChildrenServiceImplIT. Added addChildrenToParent and removeChildrenFromParent to ProjectOrderedChildrenService.
…drenManager from MoveToParentActionHandler and MoveHierarchyNodeActionHandler. Refactored MoveToParentActionHandler
…ratorFactory as it is in main-WHO
…o support userId. added overrideExisting for ProcessUploadedSiblingsOrderingCommandHandler. Updated ProcessUploadedSiblingsOrderingCommandHandler tests. Still need to update ProjectOrderedChildrenServiceImplIT tests for overrideExisting true/false scenarios.
…cenarios for importMultipleProjectOrderedChildren using overrideExisting flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.