-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement save children ordering #76
Closed
alexsilaghi
wants to merge
28
commits into
154-support-sibling-ordering-from-main
from
implement-save-children-ordering
Closed
Implement save children ordering #76
alexsilaghi
wants to merge
28
commits into
154-support-sibling-ordering-from-main
from
implement-save-children-ordering
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estCase by make it deterministic and free from order
- Moved DisplayContext to ui package because it's more general that hierarchy stuff - Added selectedPaths to DisplayContext - Added ViewId - Added ViewNodeId - Added rules for selecting HierarchyDescriptors - Added a repository for rules - Added unit tests and integration tests
…he new structure for ProjectOrderedChildren. Struggeled to create integration test for GetEntityHierarchyChildrenActionHandler, eventually scrapped it and create integration test for ProjectOrderedChildrenServiceImplIT. Added addChildrenToParent and removeChildrenFromParent to ProjectOrderedChildrenService.
…ng-from-main 154 support sibling ordering from main
…en-ordering # Conflicts: # src/main/java/edu/stanford/protege/webprotege/ApplicationBeansConfiguration.java # src/main/java/edu/stanford/protege/webprotege/hierarchy/GetEntityHierarchyChildrenActionHandler.java # src/main/java/edu/stanford/protege/webprotege/hierarchy/ordering/ProjectOrderedChildren.java # src/main/java/edu/stanford/protege/webprotege/hierarchy/ordering/ProjectOrderedChildrenRepository.java # src/main/java/edu/stanford/protege/webprotege/hierarchy/ordering/ProjectOrderedChildrenRepositoryImpl.java # src/main/java/edu/stanford/protege/webprotege/hierarchy/ordering/ProjectOrderedChildrenService.java # src/main/java/edu/stanford/protege/webprotege/hierarchy/ordering/ProjectOrderedChildrenServiceImpl.java # src/test/java/edu/stanford/protege/webprotege/hierarchy/ordering/ProjectOrderedChildrenServiceImplIT.java
Fixed flaky test shouldGetClsAsRootEntity in SubjectClosureResolver_TestCase.java
# Conflicts: # pom.xml # src/main/java/edu/stanford/protege/webprotege/ApplicationBeansConfiguration.java
Implemented DisplayContext for selecting hierarchy descriptors
…en-ordering # Conflicts: # src/main/java/edu/stanford/protege/webprotege/ApplicationBeansConfiguration.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementing the method for saving children ordering.