Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registers: support writing axis acceleration value #337

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

registers: support writing axis acceleration value #337

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
75a5ba3
registers: support writing axis acceleration value
gudnimg Dec 23, 2024
f61450d
registers: fix unit of acceleration values
gudnimg Dec 25, 2024
aa20e01
Improve accuracy in axisUnitToTruncatedUnit
gudnimg Dec 25, 2024
79b0d0b
tests: load_filament: idler homing is not invalidated
gudnimg Dec 27, 2024
c2bf5fc
tests: homing: cleanup SimulateFailedHomeFirstTime
gudnimg Dec 27, 2024
0e3d61b
tests: homing: improve SimulateIdlerHoming
gudnimg Dec 27, 2024
1061b5d
idler: adjust distance threshold
gudnimg Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/modules/idler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ void Idler::FinishMove() {
}

bool Idler::StallGuardAllowed(bool forward) const {
const uint8_t checkDistance = forward ? 220 : 200;
const uint8_t checkDistance = forward ? 200 : 180;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can tighten these values closer to 225°

return AxisDistance(mm::axisUnitToTruncatedUnit<config::U_deg>(mm::motion.CurPosition<mm::Idler>())) > checkDistance;
}

Expand Down
Loading