Implement a search counter, next to the page counter #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sebastinas
requested changes
Aug 3, 2024
| unsigned int number_of_pages = zathura_document_get_number_of_pages(zathura->document); | ||
| unsigned int current_page_number = zathura_document_get_current_page_number(zathura->document); | ||
| zathura->global.total_search_results = 0; | ||
| zathura->global.current_search_result = 0; |
There was a problem hiding this comment.
Add an empty line in between and avoid the reformatting of the two lines above.
There was a problem hiding this comment.
Please skip the reformatting of lines 413 and 414.
|
@sebastinas Sorry for the late reply. I made the changes that you requested, but actually all these previous changes came from |
laomuon
force-pushed
the
450-display-match-counters
branch
from
b43e1ca
to
0f01136
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step at implementing the search counter.
Fixes #450