Remove IREE solver #4585
Open
Remove IREE solver #4585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am expecting some stuff to fail and for this branch to require additional changes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4585 +/- ##
===========================================
- Coverage 99.26% 99.20% -0.06%
===========================================
Files 302 302
Lines 22889 22705 -184
===========================================
- Hits 22721 22525 -196
- Misses 168 180 +12 ☔ View full report in Codecov by Sentry. |
kratman
commented
Nov 13, 2024
| @@ -336,7 +336,7 @@ def no_internet_connection(): | |||
| conn = socket.create_connection((host, 80), 2) | |||
| conn.close() | |||
| return False | |||
| except socket.gaierror: | |||
| except (socket.gaierror, TimeoutError): | |||
There was a problem hiding this comment.
Unrelated, but this popped up while I was testing. It looked like a random network error
kratman
requested review from
martinjrobins,
Saransh-cpp,
agriyakhetarpal,
arjxn-py,
a team,
rtimms,
valentinsulzer,
TomTranter and
MarcBerliner
as code owners
|
@jsbrittain Can you look at this too please? |
martinjrobins
requested changes
Nov 13, 2024
| @@ -7,7 +7,6 @@ on: | |||
| env: | |||
| FORCE_COLOR: 3 | |||
| PYBAMM_IDAKLU_EXPR_CASADI: ON | |||
| PYBAMM_IDAKLU_EXPR_IREE: ON | |||
There was a problem hiding this comment.
Can we please leave in the IREE solver code and just turn off this flag so it is not tested in the CI? Its going to be a lot more difficult to re-enable this in the future if the code is deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the IREE solver. The IREE solver only supports single precision and is difficult to update. It might be re-added in the future when it is more stable.
Fixes #4521
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: