Respect repr on fields when logging a dataclass (#592)

logfire/_internal/json_encoder.py

@@ -250,7 +250,7 @@ def to_json_value(o: Any, seen: set[int]) -> JsonValue:
         elif is_sqlalchemy(o):
             return _get_sqlalchemy_data(o, seen)
         elif dataclasses.is_dataclass(o):
-            return {f.name: to_json_value(getattr(o, f.name), seen) for f in dataclasses.fields(o)}
+            return {f.name: to_json_value(getattr(o, f.name), seen) for f in dataclasses.fields(o) if f.repr}
         elif is_attrs(o):
             return _get_attrs_data(o, seen)
 

logfire/_internal/json_schema.py

@@ -171,7 +171,9 @@ def attributes_json_schema_properties(attributes: dict[str, Any]) -> JsonSchemaP
 def _dataclass_schema(obj: Any, seen: set[int]) -> JsonDict:
     # NOTE: The `x-python-datatype` is "dataclass" for both standard dataclasses and Pydantic dataclasses.
     # We don't need to distinguish between them on the frontend, or to reconstruct the type on the JSON formatter.
-    return _custom_object_schema(obj, 'dataclass', (field.name for field in dataclasses.fields(obj)), seen)
+    return _custom_object_schema(
+        obj, 'dataclass', (field.name for field in dataclasses.fields(obj) if field.repr), seen
+    )
 
 
 def _bytes_schema(obj: bytes, _seen: set[int]) -> JsonDict:

tests/test_json_args.py

@@ -5,7 +5,7 @@
 import sys
 from collections import deque
 from collections.abc import Sequence
-from dataclasses import dataclass
+from dataclasses import dataclass, field
 from datetime import date, datetime, time, timedelta
 from decimal import Decimal
 from enum import Enum
@@ -71,6 +71,12 @@ class MyPydanticComplexDataclass:
     t: MyPydanticDataclass
 
 
+@dataclass
+class MyReprDataclass:
+    in_repr: int
+    not_in_repr: MyDataclass = field(repr=False)
+
+
 class MySQLModel(SQLModel):
     s: int
 
@@ -577,6 +583,13 @@ class StrSubclass(str):
             },
             id='pydantic_complex_dataclass',
         ),
+        pytest.param(
+            MyReprDataclass(in_repr=1, not_in_repr=MyDataclass(t=2)),
+            'MyReprDataclass(in_repr=1)',
+            '{"in_repr":1}',
+            {'type': 'object', 'title': 'MyReprDataclass', 'x-python-datatype': 'dataclass'},
+            id='repr_dataclass',
+        ),
         pytest.param(
             ValueError('Test value error'),
             'Test value error',