Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make metric instrument methods compatible with older OTel versions #600

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

alexmojaki
Copy link
Contributor

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Nov 14, 2024

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2357b3c
Status: ✅  Deploy successful!
Preview URL: https://408c02cb.logfire-docs.pages.dev
Branch Preview URL: https://alex-metrics-context-compat.logfire-docs.pages.dev

View logs

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fb7b1dc) to head (2357b3c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #600   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          133       133           
  Lines        10505     10508    +3     
  Branches      1440      1440           
=========================================
+ Hits         10505     10508    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing different versions of OTel would have saved us on this one.

@alexmojaki alexmojaki enabled auto-merge (squash) November 14, 2024 14:12
@alexmojaki alexmojaki merged commit 183b3b2 into main Nov 14, 2024
17 checks passed
@alexmojaki alexmojaki deleted the alex/metrics-context-compat branch November 14, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants