Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt the pint + dask test to the newest version of pint #7855

Merged
merged 5 commits into from
May 25, 2023
Merged

adapt the pint + dask test to the newest version of pint #7855

merged 5 commits into from
May 25, 2023

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented May 20, 2023 •
edited
Loading

pint recently improved the support for wrapping dask, breaking our older tests. With this change, we basically require the newest version of pint (pint>=0.21.1, which should be released pretty soon) to interact with dask, as 0.21.0 did break our use of np.allclose and np.isclose. However, I guess dask support has never been properly tested and thus should be considered "experimental", anyways.

@keewis keewis added the run-upstream Run upstream CI label May 20, 2023
@keewis keewis mentioned this pull request May 20, 2023
Closed
@keewis keewis merged commit fd0ac3e into pydata:main May 25, 2023
@keewis keewis deleted the pint branch May 25, 2023 17:24
dstansby pushed a commit to dstansby/xarray that referenced this pull request Jun 28, 2023
@keewis @dstansby
adapt the pint + dask test to the newest version of pint (pydat…
1327d4b 
…a#7855)

* use the registry to create the quantities

* skip the `pint` + `dask` test before `pint=0.21`

* also parse the static version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Illviljan Illviljan Illviljan approved these changes

Assignees
No one assigned
Labels
run-upstream Run upstream CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keewis @Illviljan