-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn on incomplete concrete classes that inherit from abstract classes #7955
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0652845
to
855c354
Compare
This comment has been minimized.
This comment has been minimized.
Updated the test refs, but I'm not sure they're right. I'm getting lots of diffs for a lot of tests. Running pylint built from main on Windows 11 ( It appears I'm getting the correct output with Ubuntu 20.04, but |
for more information, see https://pre-commit.ci
Should be good now, let me know if there's any issues @DanielNoord! I had to add a print into the tester to get the results :/ |
@sshane This is quite close to being done. Do you have intention of working on it? Or shall we close it? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7955 +/- ##
==========================================
+ Coverage 95.82% 95.83% +0.01%
==========================================
Files 174 174
Lines 18810 18810
==========================================
+ Hits 18024 18026 +2
+ Misses 786 784 -2
|
This comment has been minimized.
This comment has been minimized.
@DanielNoord I'm having the same problem I did when I last worked on it, I verified my
Running |
Narrowed it down to #9688. I don't have any more time to spend on this for the time being, feel free to get it across the line if it's simple for you, else you can close. |
This comment has been minimized.
This comment has been minimized.
I was expecting each line's warnings to be compared to the annotations, not one by one! A more clear error message would have been nice 🙂 |
This comment has been minimized.
This comment has been minimized.
@DanielNoord I added the count which would have surfaced this for me much quicker, let me know if it's something you want and I can split it out
|
for more information, see https://pre-commit.ci
🤖 Effect of this PR on checked open source code: 🤖 Effect on home-assistant:
Effect on black:
Effect on pytest:
Effect on pandas:
Effect on sentry:
This comment was truncated because GitHub allows only 65536 characters in a comment. This comment was generated for commit 334651c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only needs a news entry using towncrier
. I'm fine with merging without full coverage.
Fixes: #7950
TODO: