Giving document.path to dmypy limits the daemon and makes it prone to crash
#101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to crash When you use `dmypy run -- file`, you're telling the daemon to only check that specific file, rather than checking your entire project. The daemon is still watching for all file changes, but you've limited the scope of that particular check. Difference: dmypy run (without arguments): Checks your entire project, using the configuration from your mypy.ini/setup.cfg/pyproject.toml dmypy run -- file: Only checks the specified file and its direct dependencies This is helpful in situations where you want a quick check of just one file during development, but it won't give you the complete project-wide type checking that dmypy run provides. The daemon itself maintains a cache and tracks file dependencies regardless of which command you use, but the scope of checking is determined by your command arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use
dmypy run -- file, you're telling the daemon to only check that specific file, rather than checking your entire project. The daemon is still watching for all file changes, but you've limited the scope of that particular check.Difference:
This is helpful in situations where you want a quick check of just one file during development, but it won't give you the complete project-wide type checking that dmypy run provides. The daemon itself maintains a cache and tracks file dependencies regardless of which command you use, but the scope of checking is determined by your command arguments.
Continuation of #65 :) It's still problematic for me. Seems like you don't want to change the behaviour so I did a rough attempt to add an option for it. Please advise.