Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop leaking a thread in test_race_between_idle_exit_and_job_assignment #1605

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Jun 10, 2020

It can lead to confusion, e.g.: #1604

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that will help indeed. :)

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #1605 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1605   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files         110      110           
  Lines       13838    13840    +2     
  Branches     1057     1058    +1     
=======================================
+ Hits        13796    13798    +2     
  Misses         27       27           
  Partials       15       15           
Impacted Files Coverage Δ
trio/_core/tests/test_thread_cache.py 100.00% <100.00%> (ø)

@pquentin pquentin merged commit dafa65c into python-trio:master Jun 10, 2020
@njsmith njsmith deleted the stop-leaking-a-thread branch June 10, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants