Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-122123: show all named fields in the PyStructSequence repr #122124

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

GH-122123: show all named fields in the PyStructSequence repr #122124

wants to merge 6 commits into from
+4 −5

Conversation

FFY00
Copy link
Member

@FFY00 FFY00 commented Jul 22, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 22, 2024
Open
@FFY00 FFY00 added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed awaiting core review labels Jul 22, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @FFY00 for commit f3f8edf 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 22, 2024
@FFY00 FFY00 changed the title GH-122123: show all field in the PyStructSequence repr GH-122123: show all fields in the PyStructSequence repr Jul 22, 2024
@FFY00
skip unnamed fields
a752551 
Signed-off-by: Filipe Laíns <[email protected]>
@FFY00
add news
4b04944 
Signed-off-by: Filipe Laíns <[email protected]>
@FFY00
fix news
53cd4c4 
Signed-off-by: Filipe Laíns <[email protected]>
@FFY00
actually fix news :/
2f5b59a 
Signed-off-by: Filipe Laíns <[email protected]>
@FFY00 FFY00 changed the title GH-122123: show all fields in the PyStructSequence repr GH-122123: show all named fields in the PyStructSequence repr Jul 22, 2024
sobolevn
sobolevn reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a test for this in _testcapi or somewhere similar.

@vstinner
Copy link
Member

This feature is mostly needed if the PR #122125 is merged, but I have concerns about this PR: #122123 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

@sobolevn sobolevn sobolevn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FFY00 @bedevere-bot @vstinner @sobolevn @picnixz