GH-87041: Fix incorrect indentation in argparse help #124230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savannahostrowski
changed the title
savannahostrowski
changed the title
savannahostrowski
added
3.12
Eclips4
reviewed
Sep 19, 2024
Misc/NEWS.d/next/Library/2024-09-19-03-46-59.gh-issue-87041.9Ox7Bv.rst
Outdated
Show resolved
Hide resolved
Eclips4
reviewed
Sep 19, 2024
Misc/NEWS.d/next/Library/2024-09-19-03-46-59.gh-issue-87041.9Ox7Bv.rst
Outdated
Show resolved
Hide resolved
savannahostrowski
requested review from
terryjreedy,
pganssle,
abalkin,
ericsnowcurrently,
kumaraditya303,
brettcannon,
ncoghlan and
warsaw
as code owners
In case of usage a long command along with max_help_position more than the length of the command, the command's help was incorrectly started on the new line
…x7Bv.rst Co-authored-by: Kirill Podoprigora <[email protected]>
…x7Bv.rst Co-authored-by: Kirill Podoprigora <[email protected]>
serhiy-storchaka
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
LGTM.
@savannahostrowski, did you add the author of the original PR as a co-author?
Co-authored-by: Serhiy Storchaka <[email protected]>
|
@serhiy-storchaka I applied the patch so that the original author is attributed in the commits. Would you like me to amend the news entry? |
This is not needed. If you did not mentioned them in the commit message, I would add the Co-authored-by line. |
|
Thank you @savannahostrowski for reviving activity on the argparse issues. |
This was referenced Sep 23, 2024
|
Thanks @savannahostrowski for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 23, 2024
…124230) In case of usage a long command along with max_help_position more than the length of the command, the command's help was incorrectly started on the new line. (cherry picked from commit 7ee9921) Co-authored-by: Savannah Ostrowski <[email protected]> Co-authored-by: Pavel Ditenbir <[email protected]>
|
GH-124373 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 23, 2024
…124230) In case of usage a long command along with max_help_position more than the length of the command, the command's help was incorrectly started on the new line. (cherry picked from commit 7ee9921) Co-authored-by: Savannah Ostrowski <[email protected]> Co-authored-by: Pavel Ditenbir <[email protected]>
|
GH-124374 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Sep 23, 2024
… (GH-124374) In case of usage a long command along with max_help_position more than the length of the command, the command's help was incorrectly started on the new line. (cherry picked from commit 7ee9921) Co-authored-by: Savannah Ostrowski <[email protected]> Co-authored-by: Pavel Ditenbir <[email protected]>
Yhg1s
pushed a commit
that referenced
this pull request
Sep 30, 2024
… (#124373) GH-87041: Fix incorrect indentation in argparse help (GH-124230) In case of usage a long command along with max_help_position more than the length of the command, the command's help was incorrectly started on the new line. (cherry picked from commit 7ee9921) Co-authored-by: Savannah Ostrowski <[email protected]> Co-authored-by: Pavel Ditenbir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR effectively re-opens #24177, which appears to be the correct fix but never got reviewed (I'm in the process of cleaning up some argparse bugs and noticed the corresponding issue still open).