gh-81691: Fix handling of multiple "--" (double dashes) in argparse #124233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
needs backport to 3.12
|
Thanks for putting up the PR. I was going back through a couple of other bugs in argparse related to the handling of I know that REMAINDER was made undocumented via #61252, but I think we'd probably still want to update this as well? |
|
Yes, but changing this behavior requires more significant rewriting. I am planning to do this later. |
serhiy-storchaka
changed the title
…arse Only the first one has now been removed, all subsequent ones are now taken literally.
serhiy-storchaka
force-pushed
the
argparse-double-dash
branch
from
67ed47e
to
34884b2
Compare
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 20, 2024
…arse (pythonGH-124233) Only the first one has now been removed, all subsequent ones are now taken literally. (cherry picked from commit aae1267) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-124266 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 20, 2024
…arse (pythonGH-124233) Only the first one has now been removed, all subsequent ones are now taken literally. (cherry picked from commit aae1267) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-124267 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Sep 20, 2024
…parse (GH-124233) (GH-124267) Only the first one has now been removed, all subsequent ones are now taken literally. (cherry picked from commit aae1267) Co-authored-by: Serhiy Storchaka <[email protected]>
savannahostrowski
pushed a commit
to savannahostrowski/cpython
that referenced
this pull request
Sep 22, 2024
…arse (pythonGH-124233) Only the first one has now been removed, all subsequent ones are now taken literally.
savannahostrowski
pushed a commit
to savannahostrowski/cpython
that referenced
this pull request
Sep 22, 2024
…arse (pythonGH-124233) Only the first one has now been removed, all subsequent ones are now taken literally.
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 7, 2024
…parse (GH-124233) (GH-124266) Only the first one has now been removed, all subsequent ones are now taken literally. (cherry picked from commit aae1267) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the first one has now been removed, all subsequent ones are now taken literally.