Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-124153: Remove _PyType_GetModuleByDef2 private function #124262

Closed
wants to merge 3 commits into from
Closed

gh-124153: Remove _PyType_GetModuleByDef2 private function #124262

wants to merge 3 commits into from
+5 −29

Conversation

neonene
Copy link
Contributor

@neonene neonene commented Sep 20, 2024 •
edited by bedevere-app bot
Loading

This function was introduced in #117578, which will no longer be used superseded by #124261.

cc @encukou

@bedevere-app bedevere-app bot mentioned this pull request Sep 20, 2024
Closed
6 tasks
vstinner
vstinner reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must update Modules/_decimal/_decimal.c: see the warnings.

@vstinner
Copy link
Member

I suggest to mark this PR as a draft and wait until #124261 is merged.

@neonene neonene marked this pull request as draft September 20, 2024 11:29
@neonene

This comment was marked as outdated.

Sign in to view
@vstinner vstinner mentioned this pull request Sep 24, 2024
Merged
@neonene
Copy link
Contributor Author

neonene commented Sep 24, 2024

Migrated to #124261.

@neonene neonene closed this Sep 24, 2024
@neonene neonene deleted the byedef2 branch September 26, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neonene @vstinner