Tests: fix race condition in output #17681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests (`testForIterable`, `testYieldNested`) consistently fail on my machine. I suspect this is because some output is printed stdout and some to stderr. Since the streams are not synchronized this is inherently racy.
robsdedude
force-pushed
the
tests/fix/output-race
branch
from
951cc39
to
dd39f86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests (
testForIterable,testYieldNested) consistently fail on my machine. I suspect this is because some output is printed to stdout and some to stderr. Since the streams are not synchronized this is inherently racy.