Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 775: Make zlib required to build Python #4281

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

StanFromIreland
Copy link

@StanFromIreland StanFromIreland commented Feb 24, 2025

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

📚 Documentation preview 📚: https://pep-previews--4281.org.readthedocs.build/pep-0775/

@hugovk
Copy link
Member

hugovk commented Feb 24, 2025

GitHub Markdown tip: when adding an x, if you remove the space inside the square brackets, it'll render it as a checked checkbox. This:

* [ x] abc
* [x] def

Renders as:

  • [ x] abc
  • def

@AA-Turner
Copy link
Member

Just for personal interest, is there a link to the discussion that preceeded creating this PEP? I hadn't realised there was going to be one for this change!

A

@hugovk hugovk changed the title PEP 775 (new): Make zlib required to build Python PEP 775: Make zlib required to build Python Feb 25, 2025
@encukou
Copy link
Member

encukou commented Feb 25, 2025

There is, https://discuss.python.org/t/23062 as linked in Post-History.
The SC could probably allow this change without a PEP, but it's a good way to summarize the discussion.

@encukou encukou added the new-pep A new draft PEP submitted for initial review label Feb 25, 2025
@StanFromIreland
Copy link
Author

@hugovk any reason to change the title? (new) is a good clarification that it is not to do with an existing pep?

@hugovk
Copy link
Member

hugovk commented Feb 25, 2025

This is our custom and what the template asks for:

  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header

We have a new-pep A new draft PEP submitted for initial review label for new PEPs.

Running pep next with https://github.com/hugovk/pepotron won't pick up the custom title and will suggest 775 again.

@StanFromIreland StanFromIreland marked this pull request as ready for review February 26, 2025 08:25
@StanFromIreland StanFromIreland requested a review from a team as a code owner February 26, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pep A new draft PEP submitted for initial review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants