fix some abstract classes in Python 2 #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
approved these changes
Jun 16, 2018
| @@ -1,12 +1,15 @@ | |||
| # Stubs for cStringIO (Python 2.7) | |||
| # See https://docs.python.org/2/library/stringio.html | |||
|
|
|||
| from abc import ABCMeta | |||
| from typing import overload, IO, List, Iterable, Iterator, Optional, Union | |||
| from types import TracebackType | |||
|
|
|||
| # TODO the typing.IO[] generics should be split into input and output. | |||
There was a problem hiding this comment.
This is actually a good idea. Some other languages have Reader and Writer classes. We can have structure like this:
class Reader(Generic[AnyStr]):
# basic read methods
class Writer(Generic[AnyStr]):
# basic write methods
class IO(Reader[AnyStr], Writer[AnyStr]):
# some additional rarely used methodsDo we have an issue to track this?
There was a problem hiding this comment.
I don't think so, feel free to open one. I'm a bit hesitant to fiddle with the IO class hierarchy though.
There was a problem hiding this comment.
OK, opened python/typing#564
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1476.
This fixes about half of the issues in the 2.7 stubs.