Update gettext translations #7636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use a protocol instead of `IO` for `fp` argument. * Annotate a few missing return types. * Mark some class constants as final. Fixes: python#7628
srittau
commented
Apr 16, 2022
Comment on lines
+71
to
+74
| class _TranslationsReader(Protocol): | ||
| def read(self) -> bytes: ... | ||
| # optional: | ||
| # name: str |
There was a problem hiding this comment.
I didn't use SupportsRead deliberately:
- The
__lengthargument toread()is not required. - To document the optional
namefield. We could add it if something like Optional class and protocol fields and methods typing#601 gets implemented.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JelleZijlstra
approved these changes
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOforfpargument.Fixes: #7628