Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added RecreateNodeAnnotationKey const #16

Merged
merged 12 commits into from
Sep 16, 2024
Merged

Added RecreateNodeAnnotationKey const #16

merged 12 commits into from
Sep 16, 2024

Conversation

Robert-Stam
Copy link
Contributor

@Robert-Stam Robert-Stam commented Sep 13, 2024 •
edited
Loading

And improved documentation for RestartedAtAnnotationKey

This is to implement: https://github.com/qdrant/cloud-pm/issues/1376

@Robert-Stam
Added RecreateNodeAnnotationKey const
54d8d28 
And improved documentation for RestartedAtAnnotationKey
@Robert-Stam Robert-Stam added the enhancement New feature or request label Sep 13, 2024
@Robert-Stam Robert-Stam self-assigned this Sep 13, 2024
@Robert-Stam Robert-Stam marked this pull request as ready for review September 13, 2024 14:05
@Robert-Stam Robert-Stam requested a review from a team as a code owner September 13, 2024 14:05
@Robert-Stam Robert-Stam requested review from bashofmann and a team September 13, 2024 14:17
pedjak
pedjak reviewed Sep 16, 2024
View reviewed changes
api/v1/qdrantcluster_types.go Outdated Show resolved Hide resolved
api/v1/qdrantcluster_types.go Outdated Show resolved Hide resolved
api/v1/qdrantcluster_types.go Outdated Show resolved Hide resolved
pedjak
pedjak approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a minor thing about relaxing the annotation value

api/v1/qdrantcluster_types.go Outdated Show resolved Hide resolved
pedjak
pedjak reviewed Sep 16, 2024
View reviewed changes
api/v1/qdrantcluster_types.go Outdated Show resolved Hide resolved
api/v1/qdrantcluster_types.go Show resolved Hide resolved
@Robert-Stam Robert-Stam merged commit 3752f72 into main Sep 16, 2024
2 checks passed
@Robert-Stam Robert-Stam deleted the enh/roberts/recreate-annot branch September 16, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedjak pedjak pedjak approved these changes

@bashofmann bashofmann Awaiting requested review from bashofmann

Assignees

@Robert-Stam Robert-Stam

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Robert-Stam @pedjak