Added to the readme #24350
Open
Added to the readme #24350
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to explain mcu variants
zvecr
reviewed
Sep 1, 2024
keyboards/magic_force/mf34/readme.md
Outdated
| @@ -1,3 +1,6 @@ | |||
| # DEPENDING ON WHERE OR WHEN YOU PURCHASED THIS KEYBOARD, YOU MAY HAVE A DIFFERENT MCU AND BOOTLOADER THAN WHAT THIS FIRMWARE IS LOOKING FOR | |||
There was a problem hiding this comment.
This should not be at the top of the file, also the suggestions for Geehy Programmer are redundant as you can still use dfu-util if the right DFU_ARGS are used.
Ideally none of this would be added, and either
- A new revision added with the correct
apm32-dfubootloader set - The wildcard added that is on many other APM32F072 boards
filterpaper
reviewed
Sep 2, 2024
Comment on lines
+25
to
+26
| **Depending on where or when you bought this keyboard, you may have a different mcu and bootloader.** | ||
| This code was made for devices with the STM32F072 chip. Some are now being sold with the APM32F072 chip. The VID and PID on these variants are the same until put into DFU mode. There are 2 ways you find out which one you have. 1: you attempt to flash and get an error saying "device mismatch." 2: you open up the board and read "APM32F072 GEEHY" on the chip. If you have the Geehy chip, you should use dfu-util to flash your bin file or find and download Geehy Programmer and use that. |
There was a problem hiding this comment.
If they have switched to using APM clone, you can consider adding support for it using a suffix like #15414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The mf34 is now being sold with a different mcu than this was originally programmed for. The VID and PID have stayed the same, but once in DFU mode, they become different. Flashing with QMK Toolbox gives a device mismatch error. At the top of the readme I added how to find out which one you have, and the steps to flash if you have the newer (or knockoff?) Geehy chip.
Types of Changes
Issues Fixed or Closed by This PR
Checklist