-
-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WS2812 API rework #24364
Merged
Merged
WS2812 API rework #24364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
reviewed
Sep 5, 2024
14 tasks
14 tasks
@daskygit Could you please test the Steelseries driver changes? And in future, avoid including quantum.h where it is not directly required. |
daskygit
reviewed
Sep 21, 2024
Co-authored-by: Dasky <[email protected]>
tzarc
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some pretty huge changes to the WS2812 API in order to clean a few things up, in particular extrication of the WS2812-specific byte ordering from
rgb_led_t
.The
ws2812_setleds()
API has been replaced with the more RGB Matrix-styleinit/set_color/set_color_all/flush
system, with a new typews2812_led_t
and array of such in each driver to hold the pixel data. Theinit
function has already been implemented, so not much to do there.set_color()
andset_color_all()
simply assign the RGB components to the given index(es) in the array.flush()
mostly contains the existingsetleds()
functionality, but no longer takes the LED array and LED count as arguments.Since this is a WIP, a bunch of things will now be broken:
The LED index adjustment for split boards inrgb_matrix_drivers.c
has been removed for the moment, so split WS2812 likely no longer worksRGBLight (Underglow) has not been touched yet, this code won't compile as it relies on the old APITesting progress (RGB Matrix):
Testing progress (RGBLight):
Types of Changes
Issues Fixed or Closed by This PR
Checklist