-
-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keyboard] Add Electronlab KLOR keyboard definitions #24372
base: master
Are you sure you want to change the base?
Conversation
nouveau fichier : electronlab/klor/halconf.h nouveau fichier : electronlab/klor/keyboard.json nouveau fichier : electronlab/klor/keymaps/default/config.h nouveau fichier : electronlab/klor/keymaps/default/keymap.c nouveau fichier : electronlab/klor/keymaps/default/rules.mk nouveau fichier : electronlab/klor/klor.c nouveau fichier : electronlab/klor/klor.h nouveau fichier : electronlab/klor/lib/glcdfont.c nouveau fichier : electronlab/klor/lib/klorimation.h nouveau fichier : electronlab/klor/lib/klounds.h nouveau fichier : electronlab/klor/mcuconf.h nouveau fichier : electronlab/klor/readme.md nouveau fichier : electronlab/klor/rules.mk
supprimé : electronlab/klor/halconf.h supprimé : electronlab/klor/keyboard.json supprimé : electronlab/klor/keymaps/default/config.h supprimé : electronlab/klor/keymaps/default/keymap.c supprimé : electronlab/klor/keymaps/default/rules.mk supprimé : electronlab/klor/klor.c supprimé : electronlab/klor/klor.h supprimé : electronlab/klor/lib/glcdfont.c supprimé : electronlab/klor/lib/klorimation.h supprimé : electronlab/klor/lib/klounds.h supprimé : electronlab/klor/mcuconf.h supprimé : electronlab/klor/readme.md supprimé : electronlab/klor/rules.mk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a preliminary review which points out the most obvious places that should be fixed. In particular, I did not actually look at the content of the default
keymap, because it violates one of the items in the PR Checklist:
- default keymaps should be "pristine"
You may be able to add a "pristine" default
keymap, and provide your fancy keymap as a “vendor” keymap. Also keep in mind that QMK Configurator currently generates a bare keymap that expands to just the keymaps
array init and nothing else (and it would be a standalone keymap which does not inherit anything from default
, so any code or configuration which is required for the keyboard to work must be at the keyboard level, not in the default
keymap).
Thank you very much for the immensely helpful code review. This has helped me quite a lot progress in the migration to json definitions which still had some hidden secrets. Let me know of any further changes you deem necessary. |
Totally cleaned up the default keymap.c for ultra minimal mapping and created a vendor specific keymap directory with extra settings enabled |
modifié : keyboards/electronlab/klor/keyboard.json modifié : keyboards/electronlab/klor/keymaps/default/config.h modifié : keyboards/electronlab/klor/keymaps/default/keymap.c supprimé : keyboards/electronlab/klor/keymaps/default/rules.mk modifié : keyboards/electronlab/klor/keymaps/electronlab/config.h modifié : keyboards/electronlab/klor/keymaps/electronlab/keymap.c modifié : keyboards/electronlab/klor/keymaps/electronlab/rules.mk
modifié : keyboards/electronlab/klor/keymaps/electronlab/keymap.c renommé : keyboards/electronlab/klor/glcdfont.c -> keyboards/electronlab/klor/lib/glcdfont.c
Electronlab KLOR keyboard definitions
-Electronlab built fork of KLOR keyboard definitions for use with RP2040 MCU boards
Description
This PR aims at bringing a complete set of features for the KLOR keyboard hardware, thus requiring the use of a RP2040 MCU due to space constraints on Atmega AVR chips.
Current version compiles without errors and enables all supported embedded hardware, as well as ability to chose any of the 4 layouts of the KLOR keyboard.
It is an initial PR and will likely require heavy scrutiny and revisions. I understand QMK aims at a minimal set of default features but the goal of this keyboard being to be feature rich, I have found many users struggling while trying to implement various functionalities. The goal of this PR is to bring a set of config files ready to be compiled with as clean as possible code following latest standard and syntax.
Types of Changes
Issues Fixed or Closed by This PR
Allows KLOR keyboard users to have access to a fully featured firmware which is currently impossible :
Checklist