Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed improvements to qmk find. #24385

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Speed improvements to qmk find. #24385

merged 4 commits into from
Nov 8, 2024

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Sep 10, 2024

Description

As discussed on discord.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team September 10, 2024 13:38
@github-actions github-actions bot added python cli qmk cli command labels Sep 10, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 26, 2024
@tzarc tzarc added the breaking_change_2024q4 Targeting breaking changes Q4 2024 label Nov 2, 2024
elpekenin
elpekenin approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@elpekenin elpekenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzarc tzarc removed the breaking_change_2024q4 Targeting breaking changes Q4 2024 label Nov 8, 2024
@zvecr zvecr merged commit 580d18d into qmk:master Nov 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpekenin elpekenin elpekenin approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
awaiting review cli qmk cli command python stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tzarc @zvecr @elpekenin @drashna