Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keyboard ilovbee B87 #24387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yangzheng20003
Copy link

@yangzheng20003 yangzheng20003 commented Sep 11, 2024

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@yangzheng20003
Copy link
Author

This is only a purely wired program.

@Cipulot
Copy link
Contributor

Cipulot commented Sep 11, 2024

This is only a purely wired program.

No it is not, stop lying about trying to merge boards just for the sake of it, going against the licensing terms.

Nice fail opening this too and confirming the suspects: #24386

Comply with the license and don't try to sneak in code like this. #24085

For reference, YT video review of this board that clearly states and shows the model board you're trying to merge and can be seen plain as day that it's tri-mode:

https://www.youtube.com/watch?v=keBXeWYEve8&ab_channel=StudioSC

@tzarc for reading and label application

@Cipulot
Copy link
Contributor

Cipulot commented Sep 11, 2024

More proof as if the above wasn't enough:

Screenshot 2024-09-11 at 10 17 18 AM Screenshot 2024-09-11 at 10 18 19 AM Amazon link: https://www.amazon.com/iLovBee-Wireless-Mechanical-Bluetooth-Swappable/dp/B0D1XLXGBK?th=1

plus the other 5 YT review videos...

@tzarc
Copy link
Member

tzarc commented Sep 11, 2024

@Cipulot thanks for letting the QMK team know.

I'll discuss within the team but I think we're close to the point where we're going to start banning either individuals, vendors, or specific hardware providers. This is no longer a workable situation.

@tzarc tzarc added needs-wireless-code needs-core-wireless Waiting on a core-side Wireless/Bluetooth/LPM implementation. invalid labels Sep 11, 2024
@yangzheng20003
Copy link
Author

Oh, this version is only the wired version of the keyboard. As for the three-mode part, we also have an open source wireless part, but it has not been merged into the main branch. We did not request to merge the three-mode of the same model. They have typical differences, such as different PID VID, etc. The keyboard version currently uploaded is also only a limited version

@tzarc
Copy link
Member

tzarc commented Sep 11, 2024

Oh, this version is only the wired version of the keyboard. As for the three-mode part, we also have an open source wireless part, but it has not been merged into the main branch. We did not request to merge the three-mode of the same model. They have typical differences, such as different PID VID, etc. The keyboard version currently uploaded is also only a limited version

Consider this comment an official request from copyrights holders that you now have 30 days to provide full sources for both the wired and wireless versions of your board, otherwise your license to use QMK will be officially revoked.

This source code needs to be the 100% identical copy of the code of the as-shipped boards, not a cut down or modified copy -- the exact copy of the source code as-shipped and marketed.

As per GPL requirements you also need to supply full instructions on how it was built in order for others to replicate, which versions of tooling were used such as compilers, and any related pieces of information required to reproduce the binary. Once supplied I'll verify the procedure and ensure that the binaries match -- then and only then will we be in a place to say that your license to use QMK is not revoked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid keyboard keymap needs-core-wireless Waiting on a core-side Wireless/Bluetooth/LPM implementation. needs-wireless-code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants