Fix hierarchy request error with empty yield #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jembezmamy thanks for adding this! To get this merged, we'll need to make sure your commits are verified: let me know if the instructions of github are enough to solve it, otherwise we can do this together. |
SkoebaSteve
reviewed
Jan 23, 2025
| {{yield}} | ||
| {{/if}} | ||
| </Tag> | ||
| {{#let (this.or @hasBlock (has-block)) as |normalizedHasBlock|}} |
There was a problem hiding this comment.
Looks like a good patch to solve the problem we're facing with wrapping the bridge and yielding content. The original fix (using has-block) was already a patch. Long term, I think we'll need to fix the root cause in the modifier.
Could you add it as an issue in github so we'll keep track of it?
There was a problem hiding this comment.
Let's log it in the existing issue #30
SkoebaSteve
approved these changes
Jan 23, 2025
|
I fixed commit signing so now it's ready for merge |
|
Hey @SkoebaSteve, can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
@hasBlockargument toReactBridgeallowing to bypass the empty block error described in issue #30. When the argument is empty,(has-block)helper will be used - same as before. So the change is backward-compatible.I added a failing test demonstrating the issue. It happens only when an empty blocked is passed and an argument is updated, causing an re-render.