Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: networkx 2 changes the behavior of out_degree #1996

Merged
merged 1 commit into from
Oct 26, 2017

Conversation

richafrank
Copy link
Member

For #1995

@richafrank richafrank requested a review from ssanderson October 26, 2017 14:03
@ssanderson
Copy link
Contributor

This looks like the right change for now. I tried just updating the zipline logic that interacts with networkx (which is pretty minimal), but it looks like there's some upstream breakage in odo with the latest networkx as well, so 👍 .

@ssanderson
Copy link
Contributor

xref blaze/odo#579 for the odo breakage.

@richafrank
Copy link
Member Author

Oh, thanks for looking - that's too bad re: odo.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.222% when pulling 93e1aae on networkx-less-than-2 into 0770d3b on master.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 26, 2017

Coverage Status

Coverage remained the same at 87.222% when pulling 93e1aae on networkx-less-than-2 into 0770d3b on master.

@richafrank richafrank merged commit 61c8869 into master Oct 26, 2017
@richafrank richafrank deleted the networkx-less-than-2 branch October 26, 2017 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants