panc: Adjust grammar to allow a single trailing comma in choice types

This allows longer lists of choices to be line-wrapped more cleanly. Also add line breaks and trailing commas to several tests to ensure this is tested.
quattor · Jan 27, 2025 · bb3944c · bb3944c
1 parent dd39350
commit bb3944c
Show file tree

Hide file tree

Showing 6 changed files with 33 additions and 8 deletions.
diff --git a/panc/src/main/jjtree/PanParser.jjt b/panc/src/main/jjtree/PanParser.jjt
@@ -713,7 +713,7 @@ org.quattor.pan.ttemplate.SourceRange typeSpec() #TypeSpec :
 org.quattor.pan.ttemplate.SourceRange baseTypeSpec() #BaseTypeSpec :
 { Token t = null, b=null, e=null; org.quattor.pan.utils.Range r = null; }
 {
-  t=<CHOICE> <LPAREN> stringLiteral() (<COMMA> stringLiteral())* e=<RPAREN>
+  t=<CHOICE> <LPAREN> stringLiteral() (LOOKAHEAD(2) <COMMA> stringLiteral())* [ <COMMA> ] e=<RPAREN>
   {
     jjtThis.setIdentifier(t.image);
     jjtThis.setSourceRange(PanParserUtils.sourceRangeFromTokens(t,(e!=null)?e:t));

diff --git a/panc/src/test/pan/Functionality/choice/choice18.pan b/panc/src/test/pan/Functionality/choice/choice18.pan
@@ -4,6 +4,11 @@
 
 object template choice18;
 
-type mychoice = choice("aa", "bb", "aaa", "bbb");
+type mychoice = choice(
+    "aa",
+    "bb",
+    "aaa",
+    "bbb",
+);
 bind '/x' = mychoice with length(SELF) == 3;
 '/x' = "aaa";
diff --git a/panc/src/test/pan/Functionality/choice/choice19.pan b/panc/src/test/pan/Functionality/choice/choice19.pan
@@ -4,6 +4,11 @@
 
 object template choice19;
 
-type mychoice = choice("aa", "bb", "aaa", "bbb");
+type mychoice = choice(
+    "aa",
+    "bb",
+    "aaa",
+    "bbb",
+);
 bind '/x' = mychoice with length(SELF) == 3;
 '/x' = "aa";
diff --git a/panc/src/test/pan/Functionality/choice/choice20.pan b/panc/src/test/pan/Functionality/choice/choice20.pan
@@ -4,6 +4,11 @@
 
 object template choice20;
 
-type mychoice = choice("aa", "bb", "aaa", "bbb");
+type mychoice = choice(
+    "aa",
+    "bb",
+    "aaa",
+    "bbb",
+);
 bind '/x' = mychoice with length(SELF) == 3;
 '/x' = "ddd";
diff --git a/panc/src/test/pan/Functionality/choice/choice21.pan b/panc/src/test/pan/Functionality/choice/choice21.pan
@@ -4,6 +4,11 @@
 
 object template choice21;
 
-type mychoice = choice("aa", "bb", "aaa", "bbb");
+type mychoice = choice(
+    "aa",
+    "bb",
+    "aaa",
+    "bbb",
+);
 bind '/x' = mychoice(3);
-'/x' = "aaa";
+'/x' = "aaa";
diff --git a/panc/src/test/pan/Functionality/choice/choice22.pan b/panc/src/test/pan/Functionality/choice/choice22.pan
@@ -4,6 +4,11 @@
 
 object template choice22;
 
-type mychoice = choice("aa", "bb", "aaa", "bbb");
+type mychoice = choice(
+    "aa",
+    "bb",
+    "aaa",
+    "bbb",
+);
 bind '/x' = mychoice(3);
-'/x' = "aa";
+'/x' = "aa";