node/webpack fix w/ support for tests #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with added support for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for node webpack environments, solution based off #239 but with added support for tests.
Please pay special attention to fetch-node.spec.js line #9--as I don't understand what's going on with the Promise context but that change resulted in all tests passing. I may be cheating by making that change, as node-fetch probably uses node's native Promise implementation so it's making the tests invalid. If that's the case--then I'm not sure how to fix it.
Edit: If this is accepted, we need to add the new tests to be included in github's PR checks.