Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: GM.xmlHttpRequest returns promise and supports multiple data types #716

Merged
merged 12 commits into from
Sep 17, 2024
Merged

feat: GM.xmlHttpRequest returns promise and supports multiple data types #716

merged 12 commits into from
Sep 17, 2024

Conversation

ACTCD
Copy link
Collaborator

@ACTCD ACTCD commented Sep 13, 2024 •
edited
Loading

@ACTCD ACTCD requested a review from quoid September 13, 2024 00:46
This was linked to issues Sep 13, 2024
GM.xmlHttpRequest send supports more data types and deprecates binary key #708
Closed
GM.xmlHttpRequest return a promise resolved with response object #712
Closed
quoid
quoid approved these changes Sep 13, 2024
View reviewed changes
Copy link
Owner

@quoid quoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just had a minor documentation related comment.

README.md Outdated Show resolved Hide resolved
@ACTCD ACTCD requested a review from quoid September 15, 2024 20:15
quoid
quoid approved these changes Sep 16, 2024
View reviewed changes
README.md Show resolved Hide resolved
src/ext/content-scripts/api.js Show resolved Hide resolved
@ACTCD ACTCD requested a review from quoid September 16, 2024 18:02
@ACTCD ACTCD merged commit 4937f21 into main Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quoid quoid quoid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ACTCD @quoid