Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rails test not being ran #649

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Fix Rails test not being ran #649

merged 2 commits into from
Jan 10, 2024

Conversation

santib
Copy link
Collaborator

@santib santib commented Jan 10, 2024

No description provided.

@santib santib mentioned this pull request Jan 10, 2024
Open
@santib santib requested review from ioquatix and grzuy January 10, 2024 14:49
@santib
Copy link
Collaborator Author

santib commented Jan 10, 2024

Previously there were 152 runs for test (3.2, rails_7_1)

With these changes we are skipping 4 tests and adding 1 more that was incorrectly being skipped. And we see that there are 149 runs (152-4+1).

@grzuy grzuy enabled auto-merge (squash) January 10, 2024 15:10
@grzuy grzuy merged commit 5124a17 into rack:main Jan 10, 2024
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzuy grzuy grzuy approved these changes

@ioquatix ioquatix Awaiting requested review from ioquatix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@santib @grzuy