mix needs to use --stdin-filename to support non-elixir files like .heex
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucianoLaratelli
force-pushed
the
patch-1
branch
from
60e47d9
to
7441fe1
Compare
…heex`
I was seeing errors formatting `.heex` files from `elixir-mode`:
```
$ apheleia-from-project-root .formatter.exs mix format -
mix format failed for stdin
** (SyntaxError) invalid syntax found on stdin.exs:1:1:
error: syntax error before: '<'
│
1 │ <html lang="en" class="[scrollbar-gutter:stable]">
│ ^
│
└─ stdin.exs:1:1
(elixir 1.17.2) lib/code.ex:999: Code.format_string!/2
(mix 1.17.2) lib/mix/tasks/format.ex:649: Mix.Tasks.Format.elixir_format/2
(mix 1.17.2) lib/mix/tasks/format.ex:668: Mix.Tasks.Format.format_file/2
(elixir 1.17.2) lib/task/supervised.ex:101: Task.Supervised.invoke_mfa/2
(elixir 1.17.2) lib/task/supervised.ex:36: Task.Supervised.reply/4
```
Looking through the help page for `mix format`, I saw:
> `--stdin-filename' - path to the file being formatted on stdin. This is useful if you are using plugins to support custom filetypes such as .heex. Without passing this flag, it is assumed that the code being passed via stdin is valid Elixir code. Defaults to "stdin.exs".
This makes that change.
LucianoLaratelli
force-pushed
the
patch-1
branch
from
7441fe1
to
847360d
Compare
LucianoLaratelli
changed the title
…heex.heex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, hope all is well.
I was seeing errors formatting
.heexfiles fromelixir-modein*apheleia-apheleia-from-project-root-log*:Looking through the help page for
mix format, I saw:This makes that change.