Fix Sprockets::Base#unescape to avoid unexpected change landed in 3.7.4
#808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….7.4. 384bf45 breaks `Sprockets::Base#unescape`. The following code has been changed between 3.7.3 and 3.7.4. ``` console $ ruby -I ./lib -r sprockets -e 'p [Sprockets::VERSION, Sprockets::Environment.new.send(:unescape, "%")]' ``` ``` ["3.7.3", "%"] ["3.7.4", "%25"] ``` This commit changes back to the behavior of 3.7.3.
|
@byroot Could you review this PR? |
|
Thanks. 3.7.5 has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
384bf45 breaks
Sprockets::Base#unescape.The following code has been changed between 3.7.3 and 3.7.4.
$ ruby -I ./lib -r sprockets -e 'p [Sprockets::VERSION, Sprockets::Environment.new.send(:unescape, "%")]'This commit changes back to the behavior of 3.7.3.
This method is not covered by auto-mated tests.
I'm not sure this method is supported officially or not.
Could you tell me we should add specs for this method.