Skip to content

Commit

Permalink
pkg/rpcserver: improve the mismatching arches error message
Browse files Browse the repository at this point in the history
Dump the whole flatrpc.ConnectRequest to the logs, so that we can
better understand the cause of google#5805
  • Loading branch information
ramosian-glider committed Feb 19, 2025
1 parent 9a14138 commit 24d0932
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/rpcserver/rpcserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ func (serv *server) connectionLoop(baseCtx context.Context, runner *Runner) erro

func checkRevisions(a *flatrpc.ConnectRequest, target *prog.Target) error {
if target.Arch != a.Arch {
return fmt.Errorf("mismatching manager/executor arches: %v vs %v", target.Arch, a.Arch)
return fmt.Errorf("mismatching manager/executor arches: %v vs %v (full request: `%#v`)", target.Arch, a.Arch, a)
}
if prog.GitRevision != a.GitRevision {
return fmt.Errorf("mismatching manager/executor git revisions: %v vs %v",
Expand Down

0 comments on commit 24d0932

Please sign in to comment.