Do not remove dependencies versions #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is related to #68 - If we make this change it should resolve that issue? |
hardys
reviewed
Oct 12, 2023
|
/cc @rohitsakala |
|
Yes, this should resolve the mentioned issue |
Kristian-ZH
force-pushed
the
do-not-remove-dep-versions
branch
from
d00f966 to
dea901e
Compare
rohitsakala
requested changes
Nov 30, 2023
|
TODO(@rohitsakala):
|
Kristian-ZH
force-pushed
the
do-not-remove-dep-versions
branch
from
dea901e to
7fd17e8
Compare
rohitsakala
approved these changes
Dec 4, 2023
|
fixes #68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #68
With this PR the dependencies versions will not be deleted when they are explicitly defined in the Chart.yaml file.
They are sometimes necessary even in the local charts in Helm because, without the versions, the global Values file does not override the subchart values files (that is expected behavior in Helm)