Update oci registry #151
Open
Update oci registry #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tashima42
reviewed
Oct 7, 2024
| func updateOCIRegistry(c *cli.Context) { | ||
|
|
||
| if OciDNS == "" || OciUser == "" || OciPassword == "" { | ||
| fmt.Printf("OCI_DNS, OCI_USER, OCI_PASS environment variables must be set to run update-oci-registry\n") |
There was a problem hiding this comment.
Suggested change
| fmt.Printf("OCI_DNS, OCI_USER, OCI_PASS environment variables must be set to run update-oci-registry\n") | |
| fmt.Println("OCI_DNS, OCI_USER, OCI_PASS environment variables must be set to run update-oci-registry") |
tashima42
reviewed
Oct 7, 2024
|
|
||
| rootFs := filesystem.GetFilesystem(getRepoRoot()) | ||
| if err := auto.UpdateOCI(rootFs, OciDNS, OciUser, OciPassword, DebugMode); err != nil { | ||
| fmt.Printf("failed to update oci registry: %v \n", err) |
There was a problem hiding this comment.
Suggested change
| fmt.Printf("failed to update oci registry: %v \n", err) | |
| fmt.Println("failed to update oci registry: ", err.Error()) |
Comment on lines
+128
to
+148
| fmt.Printf("Failed to load asset: %s; error: %s \n", asset, err.Error()) | ||
| return pushedAssets, err | ||
| } | ||
|
|
||
| // Check if the asset version already exists in the OCI registry | ||
| // Never overwrite a previously released chart! | ||
| exists, err := o.checkAsset(o.helmClient, o.DNS, chart, version) | ||
| if err != nil { | ||
| fmt.Printf("Failed to check registry for %s; error: %s \n", asset, err.Error()) | ||
| return pushedAssets, err | ||
| } | ||
| if exists { | ||
| fmt.Printf("Asset %s already exists in the OCI registry \n", asset) | ||
| return pushedAssets, fmt.Errorf("asset %s already exists in the OCI registry", asset) | ||
| } | ||
|
|
||
| fmt.Printf("Pushing asset to OCI Registry: %s \n", asset) | ||
| if err := o.push(o.helmClient, assetData, buildPushURL(o.DNS, chart, version)); err != nil { | ||
| err = fmt.Errorf("failed to push %s; error: %w ", asset, err) | ||
| fmt.Printf(err.Error()) | ||
| return pushedAssets, err |
There was a problem hiding this comment.
It would be better if we could make an atomic transaction and push all assets or push none, but if this isn't possible, you should do the same as you're doing in the last err check block, composing the errors instead of just logging them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/ecm-distro-tools#476
Imeplementing a cli command to be called by a GHA job on every chart release that will push the released chart to an OCI registry.