Support ignoreDependencies and replacePaths #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiyengar2
changed the title
aiyengar2
changed the title
|
Ran Upgrading should not cause issues to rancher/charts, but we won't need to upgrade rancher/charts with these changes unless necessary. |
pennyscissors
approved these changes
Nov 28, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignoreDependencies supports the ability to be able to drop dependencies grabbed by upstream in case a chart owner wants to omit such dependencies. For example, for Project Monitoring V2 we would like to omit all exporter charts without storing a ton of patches and exclude files.
replacePaths supports the ability to mark particular paths in a chart as ones that should not be stored under
generated-changes/patchesbut instead be stored in bothgenerated-changes/overlayandgenerated-changes/exclude. While this doesn't change any functionality per-say, it makes the contents of the generated-changes directory more readable.