Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.6] Forward Port CSI 2.3.1 #1706

Closed

Conversation

doflamingo721
Copy link
Contributor

New 2.5 charts that were forward ported to 2.6 (hidden in 2.6):
CSI 2.3.1

Copy link
Contributor

@aiyengar2 aiyengar2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages changes are missing?

Also, the first 3 commits should just be the last commit with the message "make charts". The current last commit should be your first commit, and also include packages/ changes.

@samkulkarni20
Copy link
Contributor

samkulkarni20 commented Feb 1, 2022

@aiyengar2 I don't think package changes are required or in fact should be made here. This is a forward port of 2.5 chart which will be hidden in Rancher 2.6. The only motive of forward porting it, is to make sure a Rancher upgrade containing the CSI 2.3.1 chart works. Users won't be able to do a fresh install of CSI 2.3.1 chart on Rancher 2.6. This PR is a continuation of the forward porting of 2.5 charts as done here. See item# 3 in the PR description.

New 2.5 charts that were forward ported to 2.6 (hidden in 2.6):
CPI 1.0.1
CSI 2.1.1

If we made package changes in 2.6 similar to what we have in 2.5, then it will mess up any further 2.6 chart updates in future, won't it?
CC: @pennyscissors

@doflamingo721 doflamingo721 marked this pull request as ready for review February 10, 2022 06:13
@aiyengar2
Copy link
Contributor

Ah I misunderstood the intent of this PR @samkulkarni20 @doflamingo721! Sorry for the confusion.

However, if we need to forward port charts from release-v2.5, we might as well do them all at once, so I wrote #1727 instead which uses make validate and other scripts to automatically copy over all the charts from dev-v2.5.

@doflamingo721
Copy link
Contributor Author

Closing this in favour of #1727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants