[v2.6] Release Epinio OOB #2126

pennyscissors · 2022-09-29T19:05:05Z

This PR is to release the Epinio chart OOB on behalf of the Epinio team.
The chart was validated by QA and approved here: #1814 (comment)

aiyengar2 · 2022-09-29T19:19:51Z

release.yaml

+  - 100.1.3+up1.2.5
 longhorn-crd:
- 100.1.3+up1.2.5
+  - 100.1.3+up1.2.5


these should be deleted

aiyengar2

From a charts packaging perspective, this PR seems good to me.

However, disclaimers:

Since this is a copy-paste of a package introduced in dev-v2.6, I haven't reviewed the content of the chart in this PR since I assume that that review has already been done by another reviewer with this PR in dev-v2.6. For example, I'm not blocking my approval on a review to the comment I have left on this PR regarding the upstream-version since I assume this was discussed on merging the initial PR to dev-v2.6.
I'm assuming that Epinio's QA has already validated the functionality of this chart.

Having made these disclaimers, I'm approving this PR. cc: @prachidamle @MKlimuszka let me know if I should merge or whether we need a deeper content review.

aiyengar2 · 2022-09-29T19:43:57Z

charts/epinio/100.0.0+up1.2.1/Chart.yaml

+  catalog.cattle.io/rancher-version: '>= 2.6.0-0 < 2.7.0-0'
+  catalog.cattle.io/release-name: epinio
+  catalog.cattle.io/type: cluster-tool
+  catalog.cattle.io/upstream-version: 19.0.3


is this upstream version correct?

That would be a question for the Epinio team. Maybe @andreas-kupries or @thehejik?

@pennyscissors

If the 19.0.3 refers to the epinio chart version then this is wrong. Should be 1.2.1.
See also 100.0.0+up1.2.1 in the file name.

I see this bad version in the #1814 as well. I do not remember writing it, anymore. I suspect that this is a copy/paste error I did. I.e. that I copied the annotations from some example or existing chart and then missed editing this one to the correct version number.

Apologies for that.

As this (2126) is your PR I suspect that I will not be able to fix that, right ? (I.e. no permissions)

@andreas-kupries , I thought we were all good to release? I'm confused between this message and the Slack messages. Can we merge this as is?

I thought that we were good to release. I got very much blind-sided by the issue above.

If a bogus upstream-version like the above is a blocker (*) then we are not good to release, and should fix that annotation in the modified chart. Should (can?) this be fixed in this PR ? Or should I create a PR fixing it and then @pennyscissors updates this here with it ?

(*) I do not know what Rancher (marketplace) considers a blocker vs not.

To work ahead a bit, PR #2135 is a dev-v2.6 PR which fixes the annotation in the chart, and only that.
I hope that making it was the right thing to do.

I think the call for whether the upstream version should be a blocker for release is up to the Epinio team!

From the charts side, we have approved the PR and are just waiting for your approval on the PR review @andreas-kupries before merging.

I have approved, although it was moot.

I think the call for whether the upstream version should be a blocker for release is up to the Epinio team!

My view was that with upstream-version controlling functionality in the Marketplace (something about downgrading), the severity of a mismatch between annotation and actual version would be something the Rancher team would impose on the chart writers.

In the end I decided to essentially go with "it is a blocker" and fix it now instead of in the indeterminate future.

Thanks to all who took part in the journey here, and helped.

MKlimuszka · 2022-09-29T19:52:58Z

Tomas (QA) approved releasing it today on Slack

prachidamle · 2022-09-29T20:00:22Z

@aiyengar2 @pennyscissors we should be reviewing the chart w.r.t chart packaging, not validation of content /functionality the chart is providing.
@andreas-kupries validation of the chart functionality and content would be the responsibility of Epinio team, we will only review that the chart packaging is valid to release.

aiyengar2 · 2022-10-05T20:02:30Z

Charts Checklist (built for v0.3.x charts-build-scripts)

Scripts Gist: https://gist.github.com/PennyScissors/70fac62fcbda2030415474bfea842143

Checkpoint 0: Validate `release.yaml`

Validation steps:

Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
Each chart version in release.yaml IS exactly 1 more patch version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Checkpoint 1: Compare contents of assets/ to charts/

Validation steps:

Running make unzip to regenerate the charts/ from scratch, then git diff to check differences between assets/ and charts/ yields NO differences or innocuous differences.

IMPORTANT: Do not undo these changes for future steps since we want to keep the charts/ that match the current contents of assets!

Checkpoint 2: Compare assets against index.yaml

Validation steps:

The index.yaml file has an entry for each chart version.
The index.yaml entries for each chart matches the Chart.yaml for each chart.
Each chart has ALL required annotations
- kube-version annotation
- rancher-version annotation
- permits-os annotation (indicates Windows and/or Linux)

Checkpoint 3: Logical Checks

Omitted, as described in #2126 (comment)

andreas-kupries

Approved.

pennyscissors changed the base branch from dev-v2.6 to release-v2.6 September 29, 2022 19:05

aiyengar2 reviewed Sep 29, 2022

View reviewed changes

pennyscissors force-pushed the relv26-epinio-oob branch from 11bf3eb to 9332b58 Compare September 29, 2022 19:31

aiyengar2 approved these changes Sep 29, 2022

View reviewed changes

MKlimuszka self-requested a review September 29, 2022 19:51

MKlimuszka approved these changes Sep 29, 2022

View reviewed changes

prachidamle requested a review from andreas-kupries September 29, 2022 20:02

This was referenced Oct 5, 2022

Fix upstream-version annotation #2134

Closed

Fix upstream-version annotation #2135

Merged

Steven Crespo added 2 commits October 5, 2022 11:21

Add epinio package

b988d8e

Make charts

0bd3216

pennyscissors force-pushed the relv26-epinio-oob branch from 9332b58 to 0bd3216 Compare October 5, 2022 18:24

aiyengar2 approved these changes Oct 5, 2022

View reviewed changes

aiyengar2 merged commit c8e0f1b into rancher:release-v2.6 Oct 5, 2022

andreas-kupries mentioned this pull request Oct 6, 2022

Publish Epinio on Rancher Marketplace epinio/epinio#1248

Closed

andreas-kupries reviewed Oct 6, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v2.6] Release Epinio OOB #2126

[v2.6] Release Epinio OOB #2126

pennyscissors commented Sep 29, 2022 •

edited

Loading

aiyengar2 Sep 29, 2022

pennyscissors Sep 29, 2022

aiyengar2 left a comment •

edited

Loading

aiyengar2 Sep 29, 2022 •

edited

Loading

pennyscissors Sep 29, 2022

andreas-kupries Oct 4, 2022

MKlimuszka Oct 4, 2022

andreas-kupries Oct 5, 2022

andreas-kupries Oct 5, 2022

aiyengar2 Oct 5, 2022

andreas-kupries Oct 6, 2022

MKlimuszka commented Sep 29, 2022

prachidamle commented Sep 29, 2022

aiyengar2 commented Oct 5, 2022

andreas-kupries left a comment

[v2.6] Release Epinio OOB #2126

[v2.6] Release Epinio OOB #2126

Conversation

pennyscissors commented Sep 29, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aiyengar2 left a comment • edited Loading

Choose a reason for hiding this comment

aiyengar2 Sep 29, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MKlimuszka commented Sep 29, 2022

prachidamle commented Sep 29, 2022

aiyengar2 commented Oct 5, 2022

Charts Checklist (built for v0.3.x charts-build-scripts)

Checkpoint 0: Validate release.yaml

Checkpoint 1: Compare contents of assets/ to charts/

Checkpoint 2: Compare assets against index.yaml

Checkpoint 3: Logical Checks

andreas-kupries left a comment

Choose a reason for hiding this comment

pennyscissors commented Sep 29, 2022 •

edited

Loading

aiyengar2 left a comment •

edited

Loading

aiyengar2 Sep 29, 2022 •

edited

Loading

Checkpoint 0: Validate `release.yaml`