-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-v2.11] Add previously released Istio versions to 2.11 #5214
base: dev-v2.11
Are you sure you want to change the base?
Conversation
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am under the impression that catalog.cattle.io/kube-version
should be set to >= 1.30.0-0 < 1.33.0-0
for 2.11 charts. This is something that @mallardduck told me, but I didn't get more details. I'll loop him in.
Looks good to me otherwise.
Yeah - so technically @adamkpickering is correct about the However, as long as the versions in the charts are wider than the expected range for the Rancher minor we're targeting that's OK too. And since the |
@@ -1,24 +1,24 @@ | |||
annotations: | |||
catalog.cattle.io/certified: rancher | |||
catalog.cattle.io/display-name: Istio | |||
catalog.cattle.io/kube-version: '>= 1.26.0-0 < 1.30.0-0' | |||
catalog.cattle.io/kube-version: '>= 1.27.0-0 < 1.31.0-0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - I actually see my confusion now. @adamkpickering is right that this max version isn't high enough for 2.11.
As I mentioned I don't think there's an issue if the lower k8s version is even lower than the minimum 2.11 will support. However, there would be an issue if we don't support the maximum version of k8s that 2.11 will have.
Unless this is an intentional choice to limit k8s support scope for this chart based on upstream istio requirements. If that's the case then this point is moot - otherwise, this should be < 1.33.0-0
instead of 1.31.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was intentional, Istio 1.22 does not support 1.31 or 1.32.
My understanding is that the chart can be included as long as it supports any k8s version supported by that particular version of Rancher. It won't show up in the UI unless the user is using a version specified in the annotation. I.e. it will show for a user using Rancher v2.11 + k8s 1.30 but won't for a user using Rancher v2.11 + k8s 1.31
Adding previously released Istio versions to 2.11